----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102149/ -----------------------------------------------------------
Review request for kdelibs. Summary ------- This patch improves the Calculate and Stop buttons in folder properties. Instead of having two buttons that are enabled/disabled accordingly, we only have one that toggles (technically there are still two buttons but it looks as if there was one) I removed that "Calculating..." label when there is already a size shown, instead the stop button says "Stop Calculating" and somehow serves as "indicator". Also, I added a line-break after the "Calculating..." so the label doesn't change its size making the other elements moving around. I don't know if the additional icons (view-refresh and process-cancel) add too much clutter to the visual interface since this features is not sooo important/frequently used(?) that the buttons need an icon. Diffs ----- kio/kfile/kpropertiesdialog.cpp ba56f18 Diff: http://git.reviewboard.kde.org/r/102149/diff Testing ------- Compiles and the buttons toggle (and react) fine. Thanks, Kai Uwe
