> On Aug. 9, 2011, 9:40 a.m., David Faure wrote: > > What I don't like about a single button, is that it creates a race. > > > > The calculation takes too long, you want to abort it. You click on the > > button, and half a second before, the calculation actually ended. So your > > click triggers a "Calculate" again, and the annoying calculation that you > > wanted to stop, is starting again. It can be stopped a second time of > > course, but this still makes for an annoying user experience. > > Thomas Lübking wrote: > Simple solution: disarm (or just disable) the button for about a second > after the calculation has ended, ie. clicking the button leads to no action > (should be fine since recalculating after a second has no point?) > Ideally the mousebuttonpress event would be eaten but the button doesn't > "look" disabled. > (click -> click failed -> click again) > Just disconnecting from the slot for that timeframe is suboptimal, since > the function might appear to be broken (click -> push -> nothing happens?) > Setting it disabled serves that functionality but causes visual flicker > and raises the question why the button was disabled. > > You could install an eventfilter to return true on mousepress/release > events on the button and remove it from a timerevent or singleshot timer > (just QTimer::singleShot() should be fine as well if you can ensure that you > won't run two of them at once)
"Calculating..." (time goes on) "Calculation Done" (clicking has no effect, then about 2 seconds later) "Refresh" - Christoph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102149/#review5534 ----------------------------------------------------------- On July 30, 2011, 2:51 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102149/ > ----------------------------------------------------------- > > (Updated July 30, 2011, 2:51 p.m.) > > > Review request for kdelibs. > > > Summary > ------- > > This patch improves the Calculate and Stop buttons in folder properties. > Instead of having two buttons that are enabled/disabled accordingly, we only > have one that toggles (technically there are still two buttons but it looks > as if there was one) > > I removed that "Calculating..." label when there is already a size shown, > instead the stop button says "Stop Calculating" and somehow serves as > "indicator". > Also, I added a line-break after the "Calculating..." so the label doesn't > change its size making the other elements moving around. > > I don't know if the additional icons (view-refresh and process-cancel) add > too much clutter to the visual interface since this features is not sooo > important/frequently used(?) that the buttons need an icon. > > > Diffs > ----- > > kio/kfile/kpropertiesdialog.cpp ba56f18 > > Diff: http://git.reviewboard.kde.org/r/102149/diff > > > Testing > ------- > > Compiles and the buttons toggle (and react) fine. > > > Screenshots > ----------- > > Screenshot of the dialog while it is calculating > http://git.reviewboard.kde.org/r/102149/s/213/ > > > Thanks, > > Kai Uwe > >
