-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103621/
-----------------------------------------------------------

(Updated Jan. 4, 2012, 5:03 p.m.)


Review request for KDE Base Apps and KDE Runtime.


Changes
-------

Add missing change. Also fix compilation error.


Description
-------

Port the shutdown dialog to QML. Two QML themes are included: default, which 
mimics the current shutdown dialog look & fell, and countour, which is used in 
Plasma Active.


Diffs (updated)
-----

  ksmserver/shutdowndlg.cpp a09a1a7 
  ksmserver/shutdowndlg.h e5f0942 
  ksmserver/shutdown.cpp 7fd1e11 
  ksmserver/CMakeLists.txt 295b96e 
  ksmserver/themes/contour/ContourButton.qml PRE-CREATION 
  ksmserver/themes/contour/main.qml PRE-CREATION 
  ksmserver/themes/contour/metadata.desktop PRE-CREATION 
  ksmserver/themes/contour/screenshot.png PRE-CREATION 
  ksmserver/themes/default/ContextMenu.qml PRE-CREATION 
  ksmserver/themes/default/KSMButton.qml PRE-CREATION 
  ksmserver/themes/default/MenuItem.qml PRE-CREATION 
  ksmserver/themes/default/main.qml PRE-CREATION 
  ksmserver/themes/default/metadata.desktop PRE-CREATION 
  ksmserver/themes/default/screenshot.png PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/103621/diff/diff


Testing
-------

Works in Plasma Active Two using MeeGo image and KDE SC 4.8. It does not work 
in 4.7.x because the patch requires kde-runtime 4.8's declarative imports.

There is still one bug left: keyboard nagivation works with TAB, BACKSPACE, and 
arrow-keys, but only the TAB key works at first. You always have to press the 
TAB key at least once for the other keys to work for navigation. The first TAB 
press only activates the navigation, you still need a second press to actually 
move focus to the next element.


Screenshots
-----------


  http://git.reviewboard.kde.org/r/103621/s/400/


Thanks,

Lamarque Vieira Souza

Reply via email to