> On Jan. 4, 2012, 12:24 a.m., Christoph Feck wrote:
> > Very nice work, one of the things where QML makes sense.
> >
> > Are there any i18n string regressions? If possible, I would see it in 4.8
> > (maybe not 4.8.0, but backport sometimes later, after it has received
> > testing in master), but that will only work when translation files do not
> > change.
Some strings changed because no QML component supports QLabel's accelerators,
for example i18n("&Cancel") became i18n("Cancel").
> On Jan. 4, 2012, 12:24 a.m., Christoph Feck wrote:
> > ksmserver/themes/default/main.qml, line 166
> > <http://git.reviewboard.kde.org/r/103621/diff/1/?file=45373#file45373line166>
> >
> > Can you please check if it is possible to have the layout adapt to the
> > font size specified by the user? Setting a fixed pixel size is one of the
> > bugs I hoped to get fixed with a rewrite...
> >
> > (You could also check the list of other bugs we have, so that you don't
> > try to imitate the old dialog with all its bugs, but change/fix it where
> > appropiate)
I tried to do that, but the font size became smaller than the rest of the
desktop.
- Lamarque Vieira
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103621/#review9521
-----------------------------------------------------------
On Jan. 3, 2012, 5:34 p.m., Lamarque Vieira Souza wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103621/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2012, 5:34 p.m.)
>
>
> Review request for KDE Base Apps and KDE Runtime.
>
>
> Description
> -------
>
> Port the shutdown dialog to QML. Two QML themes are included: default, which
> mimics the current shutdown dialog look & fell, and countour, which is used
> in Plasma Active.
>
>
> Diffs
> -----
>
> ksmserver/CMakeLists.txt 295b96e
> ksmserver/shutdown.cpp 7fd1e11
> ksmserver/shutdowndlg.h e5f0942
> ksmserver/shutdowndlg.cpp a09a1a7
> ksmserver/themes/contour/ContourButton.qml PRE-CREATION
> ksmserver/themes/contour/main.qml PRE-CREATION
> ksmserver/themes/contour/metadata.desktop PRE-CREATION
> ksmserver/themes/default/ContextMenu.qml PRE-CREATION
> ksmserver/themes/default/KSMButton.qml PRE-CREATION
> ksmserver/themes/default/MenuItem.qml PRE-CREATION
> ksmserver/themes/default/main.qml PRE-CREATION
> ksmserver/themes/default/metadata.desktop PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/103621/diff/diff
>
>
> Testing
> -------
>
> Works in Plasma Active Two using MeeGo image and KDE SC 4.8. It does not work
> in 4.7.x because the patch requires kde-runtime 4.8's declarative imports.
>
> There is still one bug left: keyboard nagivation works with TAB, BACKSPACE,
> and arrow-keys, but only the TAB key works at first. You always have to press
> the TAB key at least once for the other keys to work for navigation. The
> first TAB press only activates the navigation, you still need a second press
> to actually move focus to the next element.
>
>
> Screenshots
> -----------
>
>
> http://git.reviewboard.kde.org/r/103621/s/400/
>
>
> Thanks,
>
> Lamarque Vieira Souza
>
>
