> On Jan. 3, 2012, 9:38 p.m., Albert Astals Cid wrote: > > ksmserver/CMakeLists.txt, line 57 > > <http://git.reviewboard.kde.org/r/103621/diff/1/?file=45363#file45363line57> > > > > no variable for kdeclarative? > > Lamarque Vieira Souza wrote: > There is one in shutdowndlg.cpp, in KSMShutdownDlg's constructor. > > Albert Astals Cid wrote: > I mean cmake variable like ${SOMETHING_SOMETHING}
I do not think so. All CMakeLists.txt throughout kde-workspace, kde-runtime and plasma-mobile add the library name directly. Do you know where those that kind of variables are defined? - Lamarque Vieira ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/#review9516 ----------------------------------------------------------- On Jan. 4, 2012, 6:41 p.m., Lamarque Vieira Souza wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103621/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2012, 6:41 p.m.) > > > Review request for KDE Base Apps and KDE Runtime. > > > Description > ------- > > Port the shutdown dialog to QML. Two QML themes are included: default, which > mimics the current shutdown dialog look & fell, and countour, which is used > in Plasma Active. > > > Diffs > ----- > > ksmserver/CMakeLists.txt 295b96e > ksmserver/Messages.sh 0aa8bab > ksmserver/shutdown.cpp 7fd1e11 > ksmserver/shutdowndlg.h e5f0942 > ksmserver/shutdowndlg.cpp a09a1a7 > ksmserver/themes/contour/ContourButton.qml PRE-CREATION > ksmserver/themes/contour/main.qml PRE-CREATION > ksmserver/themes/contour/metadata.desktop PRE-CREATION > ksmserver/themes/contour/screenshot.png PRE-CREATION > ksmserver/themes/default/ContextMenu.qml PRE-CREATION > ksmserver/themes/default/KSMButton.qml PRE-CREATION > ksmserver/themes/default/MenuItem.qml PRE-CREATION > ksmserver/themes/default/main.qml PRE-CREATION > ksmserver/themes/default/metadata.desktop PRE-CREATION > ksmserver/themes/default/screenshot.png PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/103621/diff/diff > > > Testing > ------- > > Works in Plasma Active Two using MeeGo image and KDE SC 4.8. It does not work > in 4.7.x because the patch requires kde-runtime 4.8's declarative imports. > > TODO: > > . implement something equivalent to QLabel's accelerators. > . check if there are bugs in bugs.kde.org that could be solved by this patch. > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/103621/s/400/ > > > Thanks, > > Lamarque Vieira Souza > >