----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104140/#review11090 -----------------------------------------------------------
I am a bit of layman in here (thus pardon me), but I would personally prefer a separated location for these config files. Something like either cmake/modules or in the experimental subfolder itself right next to the "CTestConfig.cmake" (I do not personally know what is the best practice here). You can see an example for cmake/modules from Stephen in grantlee, but the cmake example, about it, puts it into the $projectroot. Admittedly, it would be nice to hear some kde-buildsystem guy(s) to comment on this, like Alex, Stephen, etc. :) Thank you for your effort about it really, by the way! - Laszlo Papp On March 2, 2012, 6:01 p.m., Lamarque Vieira Souza wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104140/ > ----------------------------------------------------------- > > (Updated March 2, 2012, 6:01 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > Currently kdeclarative library does not install the KDeclarativeConfig.cmake > and KDeclarativeConfigVersion.cmake to ${LIB_INSTALL_DIR}/cmake/KDeclarative > and so other KDE programs cannot find the library using cmake's find_package > macro. > > kde-workspace, kde-runtime and plasma-mobile currently hardcode the > "kdeclarative" library name in their CMakeLists.txt, which is not ideal. Once > this patch is submitted we need to fix their CMakeLists.txt to use > "find_package(KDeclarative REQUIRED)". > > > Diffs > ----- > > experimental/libkdeclarative/CMakeLists.txt 0db647c > experimental/libkdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION > experimental/libkdeclarative/KDeclarativeConfigVersion.cmake.in > PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/104140/diff/ > > > Testing > ------- > > I can now compile kde-workspace/ksmserver without using the custom made > FindKDeclarative.cmake. > > > Thanks, > > Lamarque Vieira Souza > >