> On March 5, 2012, 8:51 p.m., Alexander Neundorf wrote: > > experimental/libkdeclarative/KDeclarativeConfig.cmake.in, line 14 > > <http://git.reviewboard.kde.org/r/104140/diff/1/?file=51648#file51648line14> > > > > I didn't check, but how is INCLUDE_INSTALL_DIR set ? > > Is it done by via find_package(KDE4) ? > > In this case, INCLUDE_INSTALL_DIR is a relative path under Windows, so > > the config file wouldn't work properly under Windows. > > Lamarque Vieira Souza wrote: > I do not know, INCLUDE_INSTALL_DIR was already used in > libkdeclarative/CMakeLists.txt before I created this patch. I am just using > it.
Any more questions about this patch? Can I push it? - Lamarque Vieira ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104140/#review11151 ----------------------------------------------------------- On March 5, 2012, 9:55 p.m., Lamarque Vieira Souza wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104140/ > ----------------------------------------------------------- > > (Updated March 5, 2012, 9:55 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > Currently kdeclarative library does not install the KDeclarativeConfig.cmake > and KDeclarativeConfigVersion.cmake to ${LIB_INSTALL_DIR}/cmake/KDeclarative > and so other KDE programs cannot find the library using cmake's find_package > macro. > > kde-workspace, kde-runtime and plasma-mobile currently hardcode the > "kdeclarative" library name in their CMakeLists.txt, which is not ideal. Once > this patch is submitted we need to fix their CMakeLists.txt to use > "find_package(KDeclarative REQUIRED)". > > > Diffs > ----- > > experimental/libkdeclarative/CMakeLists.txt 0db647c > experimental/libkdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION > experimental/libkdeclarative/KDeclarativeConfigVersion.cmake.in > PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/104140/diff/ > > > Testing > ------- > > I can now compile kde-workspace/ksmserver without using the custom made > FindKDeclarative.cmake. > > > Thanks, > > Lamarque Vieira Souza > >