----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104614/#review12509 -----------------------------------------------------------
Thanks for the patch, I've not been aware that this caching-issue can be solved like this :-) I guess this patch has not been applied to the latest master: DolphinView does not have a dir-lister anymore (it has been moved to KFileItemModel). Anyhow: Please just let me rebase the patch myself so that I can catch all cases - I'll push the patch to master during the next days. - Peter Penz On April 16, 2012, 1:26 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104614/ > ----------------------------------------------------------- > > (Updated April 16, 2012, 1:26 p.m.) > > > Review request for KDE Base Apps and Peter Penz. > > > Description > ------- > > The attached patch sets the main window on the main directory lister in > DolphinView and KIO jobs in DolphinMainWindow to ensure that login data for > remote protocols such as sftp, ftp are cached properly for the duration of > the application. Otherwise, the end user is going to end up being > unnecessarily re-prompted to enter password login information. > > Please note that this patch does not address every use of KIO or KDirLister > in Dolphin. There are other places in Dolphin's code where directory listers > and/or jobs are used without setting the main window. > > > Diffs > ----- > > dolphin/src/dolphinmainwindow.cpp 947db77 > dolphin/src/views/dolphinview.cpp 78fd56d > > Diff: http://git.reviewboard.kde.org/r/104614/diff/ > > > Testing > ------- > > > Thanks, > > Dawit Alemayehu > >
