-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104614/#review12614
-----------------------------------------------------------


This review has been submitted with commit 
ff37139bcfa02973499c753df33eba19fdc347c5 by Peter Penz to branch master.

- Commit Hook


On April 16, 2012, 1:26 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104614/
> -----------------------------------------------------------
> 
> (Updated April 16, 2012, 1:26 p.m.)
> 
> 
> Review request for KDE Base Apps and Peter Penz.
> 
> 
> Description
> -------
> 
> The attached patch sets the main window on the main directory lister in 
> DolphinView and KIO jobs in DolphinMainWindow to ensure that login data for 
> remote protocols such as sftp, ftp are cached properly for the duration of 
> the application. Otherwise, the end user is going to end up being 
> unnecessarily re-prompted to enter password login information.
> 
> Please note that this patch does not address every use of KIO or KDirLister 
> in Dolphin. There are other places in Dolphin's code where directory listers 
> and/or jobs are used without setting the main window.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp 947db77 
>   dolphin/src/views/dolphinview.cpp 78fd56d 
> 
> Diff: http://git.reviewboard.kde.org/r/104614/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

Reply via email to