> On April 17, 2012, 1:45 p.m., Sebastian Kügler wrote: > > This change is wrong, as the menu entry has nothing to do with the semantic > > meaning of the icon, and the icon is not named according to the icon spec. > > > > So the correct icon is already set here, if its look doesn't match, then > > that icon would need to be fixed. In this case, I assume you mean to better > > reflect the "online" part in the name, and I agree that it's not reflected > > in the name. Question is: does it matter where the help is located? (Surely > > does if the user is offline, but in general ... I think the "help!" part is > > important, not the "online" part.
+1 - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104621/#review12573 ----------------------------------------------------------- On April 16, 2012, 5:28 p.m., Maarten De Meyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104621/ > ----------------------------------------------------------- > > (Updated April 16, 2012, 5:28 p.m.) > > > Review request for KDE Runtime and Cornelius Schumacher. > > > Description > ------- > > Changes the 'Online help' icon in the navigation to a more fitting one.(imho) > > > Diffs > ----- > > khelpcenter/plugins/onlinehelp.desktop 540f83f > > Diff: http://git.reviewboard.kde.org/r/104621/diff/ > > > Testing > ------- > > compiled and run, works fine > > > Thanks, > > Maarten De Meyer > >
