> On April 17, 2012, 1:45 p.m., Sebastian Kügler wrote: > > This change is wrong, as the menu entry has nothing to do with the semantic > > meaning of the icon, and the icon is not named according to the icon spec. > > > > So the correct icon is already set here, if its look doesn't match, then > > that icon would need to be fixed. In this case, I assume you mean to better > > reflect the "online" part in the name, and I agree that it's not reflected > > in the name. Question is: does it matter where the help is located? (Surely > > does if the user is offline, but in general ... I think the "help!" part is > > important, not the "online" part. > > Albert Astals Cid wrote: > +1
The openSuse icons had me confused. The one I mean is 'applications-internet' The current icon is the same as most other entries: a book with a question mark. Not really wrong, but not correct/obvious either. I do however think that the 'online' part is more important. If you are in the help center EVERYTHING is 'help', it should be more obvious what the difference is between the available options to get help. And these days more and more help is located online and no longer limited to only documentation. (think forums, wiki, ...) I wish for the help center to be more of place to go when you have problems than a handy manual reader. (In all honesty changing a little icon won't make much difference) As this is my first patch I'm not sure what the policy is to do now. Close as discarded or leave open? - Maarten ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104621/#review12573 ----------------------------------------------------------- On April 16, 2012, 5:28 p.m., Maarten De Meyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104621/ > ----------------------------------------------------------- > > (Updated April 16, 2012, 5:28 p.m.) > > > Review request for KDE Runtime and Cornelius Schumacher. > > > Description > ------- > > Changes the 'Online help' icon in the navigation to a more fitting one.(imho) > > > Diffs > ----- > > khelpcenter/plugins/onlinehelp.desktop 540f83f > > Diff: http://git.reviewboard.kde.org/r/104621/diff/ > > > Testing > ------- > > compiled and run, works fine > > > Thanks, > > Maarten De Meyer > >
