----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105972/#review17299 -----------------------------------------------------------
Hi, thanks for the patch! dolphin/src/kitemviews/kitemlistcontainer.cpp <http://git.reviewboard.kde.org/r/105972/#comment13463> I don't think it's a good idea to execute QAccessible::removeFactory each time an object is deleted. Executing QAccessible::installFactory has no effect if the factory you are installing is already installed, so if more than one object of the same class are created the second call to installFactory will have no effect and the factory will be removed once one of the objects is deleted. dolphin/src/kitemviews/kitemlistview.cpp <http://git.reviewboard.kde.org/r/105972/#comment13461> I think it might be a good idea to have only one factory. dolphin/src/kitemviews/kitemlistview.cpp <http://git.reviewboard.kde.org/r/105972/#comment13462> The same comment made in KItemListContainer::~KItemListContainer applies here. - José Millán Soto On Aug. 13, 2012, 5:50 a.m., Amandeep Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105972/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2012, 5:50 a.m.) > > > Review request for Dolphin, KDE Base Apps and KDE Accessibility. > > > Description > ------- > > Added Accessibility Interfaces for Dolphin Views & Widgets, to make it > accessible. > 2 New files added in dolphin/ src/ kitemviews/ kitemlistviewaccessible.* that > contain the three new classes. > > > Diffs > ----- > > dolphin/src/CMakeLists.txt 5c1a6da > dolphin/src/kitemviews/kitemlistcontainer.cpp 5500851 > dolphin/src/kitemviews/kitemlistcontroller.cpp 88f5d9f > dolphin/src/kitemviews/kitemlistselectionmanager.cpp 383914d > dolphin/src/kitemviews/kitemlistview.h 5723b9a > dolphin/src/kitemviews/kitemlistview.cpp 72b3fd8 > dolphin/src/kitemviews/kitemlistviewaccessible.h PRE-CREATION > dolphin/src/kitemviews/kitemlistviewaccessible.cpp PRE-CREATION > dolphin/src/kitemviews/private/kitemlistviewlayouter.h da5bd1d > dolphin/src/tests/CMakeLists.txt 3f906d1 > > Diff: http://git.reviewboard.kde.org/r/105972/diff/ > > > Testing > ------- > > Focus-tracking tested with KMag / KWin. > > > Thanks, > > Amandeep Singh > >
