> On Aug. 14, 2012, 2:43 p.m., Frank Reininghaus wrote: > > Thanks for the explanations! > > > > Amandeep, could you address all issues raised here and either comment on > > them or fix them in an updated patch? Just to make sure that the patch gets > > easier to read when we continue the review and that the patch converges to > > a state that can be included in Dolphin. I hope you are not too annoyed yet > > by all our comments and ideas! We're just trying to make sure that the > > patch gets as good as it can get before it is committed.
I just uploaded the diff. As I said, your reviews are making my patch better for dolphin & better for KDE, which is more than good :) Thanks to everyone for their time :) - Amandeep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105972/#review17394 ----------------------------------------------------------- On Aug. 14, 2012, 3:01 p.m., Amandeep Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105972/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2012, 3:01 p.m.) > > > Review request for Dolphin, KDE Base Apps and KDE Accessibility. > > > Description > ------- > > Added Accessibility Interfaces for Dolphin Views & Widgets, to make it > accessible. > 2 New files added in dolphin/ src/ kitemviews/ kitemlistviewaccessible.* that > contain the three new classes. > > > Diffs > ----- > > dolphin/src/CMakeLists.txt afc190f > dolphin/src/kitemviews/kitemlistcontroller.cpp 88f5d9f > dolphin/src/kitemviews/kitemlistview.h 5723b9a > dolphin/src/kitemviews/kitemlistview.cpp 72b3fd8 > dolphin/src/kitemviews/kitemlistviewaccessible.h PRE-CREATION > dolphin/src/kitemviews/kitemlistviewaccessible.cpp PRE-CREATION > dolphin/src/kitemviews/private/kitemlistviewlayouter.h da5bd1d > dolphin/src/tests/CMakeLists.txt 3f906d1 > > Diff: http://git.reviewboard.kde.org/r/105972/diff/ > > > Testing > ------- > > Focus-tracking tested with KMag / KWin. > > > Thanks, > > Amandeep Singh > >
