----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105984/#review17622 -----------------------------------------------------------
Not a strong objection, but KonqViewManager::doSetActivePart is supposed to do this already, so I'm surprised it doesn't work? If that method isn't called in your case, then OK. - David Faure On Aug. 11, 2012, 3:58 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105984/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2012, 3:58 p.m.) > > > Review request for KDE Base Apps and David Faure. > > > Description > ------- > > The attached patch address the bug reported in #304933. Right now if > Konqueror is configured to open new tabs in the foreground, i.e. the "Open > tabs in the background" option is unchecked, then the keyboard focus is put > on the location bar instead of the view. > > > This addresses bug 304933. > http://bugs.kde.org/show_bug.cgi?id=304933 > > > Diffs > ----- > > konqueror/src/konqmainwindow.cpp 6faba58 > > Diff: http://git.reviewboard.kde.org/r/105984/diff/ > > > Testing > ------- > > > Thanks, > > Dawit Alemayehu > >
