-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105984/#review17978
-----------------------------------------------------------


This is going into the right direction.
If you move your new code from KonqView::slotStarted to KonqView::setLoading 
(if loading is true), then it will be called much earlier: when the KonqRun 
(mimetype determination job) is started for this view. This should remove the 
"visual delay" you're seeing.

- David Faure


On Aug. 20, 2012, 8:02 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105984/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2012, 8:02 p.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Description
> -------
> 
> The attached patch address the bug reported in #304933. Right now if 
> Konqueror is configured to open new tabs in the foreground, i.e. the "Open 
> tabs in the background" option is unchecked, then the keyboard focus is put 
> on the location bar instead of the view.
> 
> 
> This addresses bugs 304865 and 304933.
>     http://bugs.kde.org/show_bug.cgi?id=304865
>     http://bugs.kde.org/show_bug.cgi?id=304933
> 
> 
> Diffs
> -----
> 
>   konqueror/src/konqframe.cpp 10ed7cd 
>   konqueror/src/konqview.cpp db9ffd4 
>   konqueror/src/konqviewmanager.cpp 5352eeb 
> 
> Diff: http://git.reviewboard.kde.org/r/105984/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

Reply via email to