----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106333/#review18625 -----------------------------------------------------------
dolphin/src/dolphinpart.cpp <http://git.reviewboard.kde.org/r/106333/#comment14732> IMHO this is worse than a DolphinView::fileItemModel() method, because it will break at runtime rather than at compile time. - David Faure On Sept. 5, 2012, 4:33 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106333/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2012, 4:33 p.m.) > > > Review request for Dolphin and KDE Base Apps. > > > Description > ------- > > The following patch implements the new KParts listing notification extension > in Dolphin. This implementation does not add new signals to KFileItemModel > and DolphinView classes as the previous solution. Instead it relies on the > QObject's introspection to look for KDirLister and connect to the desired > signals. > > This solution is based on the "hack" that was originally implemented in the > directory listern plugin. However, unlike that implementation, this one will > not suffer from sudden and unexpected changes in Dolphin's code changes > because it is closer to the source and it looks for the directory lister > directly in KFileItemModel. This is something that cannot be done at the > plugin level because it would require the plugin to link against dolphin. > > > Diffs > ----- > > dolphin/src/dolphinpart.h f9c0bbf > dolphin/src/dolphinpart.cpp bf3d2a5 > > Diff: http://git.reviewboard.kde.org/r/106333/diff/ > > > Testing > ------- > > > Thanks, > > Dawit Alemayehu > >
