----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105078/#review23317 -----------------------------------------------------------
kioslave/trash/kio_trash.cpp <http://git.reviewboard.kde.org/r/105078/#comment17934> You can remove this forward-declaration, it's not needed since the function is declared before use, below. kioslave/trash/kio_trash.cpp <http://git.reviewboard.kde.org/r/105078/#comment17933> Hmm did you test this change ? :) A "return fileDisplayName;" is missing here, so basically makeDisplayName was returning an invalid QString? kioslave/trash/kio_trash.cpp <http://git.reviewboard.kde.org/r/105078/#comment17935> This comment should move up to the implementation of makeDisplayName() - David Faure On Dec. 11, 2012, 7:04 a.m., Michael Reeves wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105078/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2012, 7:04 a.m.) > > > Review request for KDE Runtime. > > > Description > ------- > > This patch makes drag-and-drop and cut/paste from trash preserve the orginal > filename instead of appending "0-". > > > This addresses bug 183403. > http://bugs.kde.org/show_bug.cgi?id=183403 > > > Diffs > ----- > > kioslave/trash/kio_trash.cpp 138bab3 > > Diff: http://git.reviewboard.kde.org/r/105078/diff/ > > > Testing > ------- > > I have used the modified io_trash module on my machine since before the KDE > 4.8 release and still use it under KDE 4.8.3. > > > Thanks, > > Michael Reeves > >
