> On Dec. 11, 2012, 4:26 p.m., David Faure wrote: > > kioslave/trash/kio_trash.cpp, line 72 > > <http://git.reviewboard.kde.org/r/105078/diff/3/?file=98268#file98268line72> > > > > Hmm did you test this change ? :) > > > > A "return fileDisplayName;" is missing here, so basically > > makeDisplayName was returning an invalid QString?
Sorry. It was late anyway fixed now - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105078/#review23317 ----------------------------------------------------------- On Dec. 11, 2012, 9:51 p.m., Michael Reeves wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105078/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2012, 9:51 p.m.) > > > Review request for KDE Runtime. > > > Description > ------- > > This patch makes drag-and-drop and cut/paste from trash preserve the orginal > filename instead of appending "0-". > > > This addresses bug 183403. > http://bugs.kde.org/show_bug.cgi?id=183403 > > > Diffs > ----- > > kioslave/trash/kio_trash.cpp 138bab3 > > Diff: http://git.reviewboard.kde.org/r/105078/diff/ > > > Testing > ------- > > I have used the modified io_trash module on my machine since before the KDE > 4.8 release and still use it under KDE 4.8.3. > > > Thanks, > > Michael Reeves > >
