----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107716/#review23658 -----------------------------------------------------------
Looks good (I'll try a full kde recompile with it, to see if it breaks anything). An addition to the kconfig_compiler unittests is missing, though, could you add that? - David Faure On Dec. 14, 2012, 1:17 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107716/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2012, 1:17 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > This patch changes the generated code so that if a property is "UrlList" in > the kcfg file, the variable that will receive it when generating the skeleton > is a KUrl::List instead a QStringList. This solves the following compiling > error: > > aleix@kubuntu:~/projects/muon/build$ make > [ 0%] Built target muonprivate_automoc > [ 0%] Building CXX object > libmuon/CMakeFiles/muonprivate.dir/MuonDataSources.o > In file included from /usr/include/kcoreconfigskeleton.h:28:0, > from /usr/include/kconfigskeleton.h:28, > from > /home/aleix/projects/muon/build/libmuon/MuonDataSources.h:8, > from > /home/aleix/projects/muon/build/libmuon/MuonDataSources.cpp:4: > /usr/include/kurl.h: In constructor ‘MuonDataSources::MuonDataSources()’: > /usr/include/kurl.h:1146:3: error: ‘KUrl::operator QString() const’ is private > /home/aleix/projects/muon/build/libmuon/MuonDataSources.cpp:38:105: error: > within this context > > > Diffs > ----- > > kdecore/kconfig_compiler/kconfig_compiler.cpp 4203d30 > > Diff: http://git.reviewboard.kde.org/r/107716/diff/ > > > Testing > ------- > > > Thanks, > > Aleix Pol Gonzalez > >