----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107716/#review29014 -----------------------------------------------------------
This review has been submitted with commit e02018941445df731873edb119b3290998375bdf by Aleix Pol to branch KDE/4.10. - Commit Hook On March 11, 2013, 3:16 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107716/ > ----------------------------------------------------------- > > (Updated March 11, 2013, 3:16 a.m.) > > > Review request for kdelibs. > > > Description > ------- > > This patch changes the generated code so that if a property is "UrlList" in > the kcfg file, the variable that will receive it when generating the skeleton > is a KUrl::List instead a QStringList. This solves the following compiling > error: > > aleix@kubuntu:~/projects/muon/build$ make > [ 0%] Built target muonprivate_automoc > [ 0%] Building CXX object > libmuon/CMakeFiles/muonprivate.dir/MuonDataSources.o > In file included from /usr/include/kcoreconfigskeleton.h:28:0, > from /usr/include/kconfigskeleton.h:28, > from > /home/aleix/projects/muon/build/libmuon/MuonDataSources.h:8, > from > /home/aleix/projects/muon/build/libmuon/MuonDataSources.cpp:4: > /usr/include/kurl.h: In constructor ‘MuonDataSources::MuonDataSources()’: > /usr/include/kurl.h:1146:3: error: ‘KUrl::operator QString() const’ is private > /home/aleix/projects/muon/build/libmuon/MuonDataSources.cpp:38:105: error: > within this context > > > Diffs > ----- > > kdecore/kconfig_compiler/kconfig_compiler.cpp 493c7d1 > kdeui/tests/kconfig_compiler/CMakeLists.txt 28e916f > kdeui/tests/kconfig_compiler/test12.cpp.ref PRE-CREATION > kdeui/tests/kconfig_compiler/test12.h.ref PRE-CREATION > kdeui/tests/kconfig_compiler/test12.kcfg PRE-CREATION > kdeui/tests/kconfig_compiler/test12.kcfgc PRE-CREATION > kdeui/tests/kconfig_compiler/test12main.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/107716/diff/ > > > Testing > ------- > > > Thanks, > > Aleix Pol Gonzalez > >
