----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108504/ -----------------------------------------------------------
Review request for kdelibs and KDE Usability. Description ------- This makes the KIconDialog (the dialog where you can choose icons for eg. folders) respect the global icon size. Almost all sizes were hardcoded but the patch does away with all of this and works fine with all icon sizes and big font sizes. Also made it aware of FontMetrics (atm with bigger fonts, they also get clipped) and adjusts the grid height accordingly. Was fun diving into that "ancient" code :) Diffs ----- kio/kfile/kicondialog.cpp b7d646f Diff: http://git.reviewboard.kde.org/r/108504/diff/ Testing ------- Yup, see screenshot. The only issue that remains is the initial size of the dialog. In the current implementation it just adds another 100px to the dialog height, which is easy, if all the sizes are known and fixed, but with variing sizes this becomes an issue and I could not think of a proper solution. See code comment below. File Attachments ---------------- Icon Dialog with 200dpi http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/icondialog.png Icon Dialog with 200dpi (without patch) http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/icondialog2.png Thanks, Kai Uwe Broulik
