----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110138/#review31652 -----------------------------------------------------------
plasma/private/dialogshadows.cpp <http://git.reviewboard.kde.org/r/110138/#comment23561> this looks slightly like a recursion? (i think void DialogShadows::Private::freeX11Pixmaps() and void DialogShadows::Private::clearPixmaps() are twisted) - Thomas Lübking On April 27, 2013, 4:16 a.m., Ömer Fadıl Usta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110138/ > ----------------------------------------------------------- > > (Updated April 27, 2013, 4:16 a.m.) > > > Review request for kdelibs, Aaron J. Seigo, Martin Gräßlin, and Marco Martin. > > > Description > ------- > > I was getting lots of errors while moving my mouse over system tray before > this patch.( http://paste.kde.org/730880/ ) > Also this patch fixes a forgetten check before freeing a already freed pixmap > > > Diffs > ----- > > plasma/private/dialogshadows_p.h a2d62cc > plasma/private/dialogshadows.cpp e787fd4 > > Diff: http://git.reviewboard.kde.org/r/110138/diff/ > > > Testing > ------- > > Looks like it is working fine > > > Thanks, > > Ömer Fadıl Usta > >
