> On April 27, 2013, 10:40 a.m., Thomas Lübking wrote: > > plasma/private/dialogshadows.cpp, line 371 > > <http://git.reviewboard.kde.org/r/110138/diff/2/?file=141212#file141212line371> > > > > this looks slightly like a recursion? > > (i think void DialogShadows::Private::freeX11Pixmaps() and void > > DialogShadows::Private::clearPixmaps() are twisted) > > Thomas Lübking wrote: > RR110029 was submitted a week ago. > > However I don't see a self-calling freeX11Pixmaps() that does not free > the pixmaps but clear the caches there... ;-) > (look at your patched version, lines 368-371)
you are right i messed up patches :D give me 1 min. Also i gived wrong review for checking :D https://git.reviewboard.kde.org/r/110208/ <-- This will commit today or tomorrow then i will add the otherpart on it. But i made a mistake while passing that into mine :) sorry about this mess. - Ömer Fadıl ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110138/#review31652 ----------------------------------------------------------- On April 27, 2013, 11:01 a.m., Ömer Fadıl Usta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110138/ > ----------------------------------------------------------- > > (Updated April 27, 2013, 11:01 a.m.) > > > Review request for kdelibs, Aaron J. Seigo, Martin Gräßlin, and Marco Martin. > > > Description > ------- > > I was getting lots of errors while moving my mouse over system tray before > this patch.( https://git.reviewboard.kde.org/r/110029/ ) > Also this patch fixes a forgetten check before freeing a already freed pixmap > > > Diffs > ----- > > plasma/private/dialogshadows_p.h a2d62cc > plasma/private/dialogshadows.cpp e787fd4 > > Diff: http://git.reviewboard.kde.org/r/110138/diff/ > > > Testing > ------- > > Looks like it is working fine > > > Thanks, > > Ömer Fadıl Usta > >
