> On April 19, 2013, 1:13 p.m., David Faure wrote: > > Well, yes, it looks nicer to my eyes because I'm not very good at german > > (and your "before" screenshot is in german) :-P > > > > More seriously I'm not sure this will always work... what if the error > > message is much longer? Shouldn't it start on its own line so we don't > > confuse it with the kio_ftp-provided sentence, in general? > > Thomas Lübking wrote: > What esp. should not happen is to just print "421" but indicate that this > is "Error #421" or similar. > > More 2¢: > For more visual appeal i'd suggest to emphasize the upper (main) line (h2 > or maybe just b), get rid of the empty line(s? - trailing one) and ideally > get the close button top aligned (esp. since it almost looks like the icon...) > > Kai Uwe Broulik wrote: > I have no idea how long that message can actually get and if it will > always start with the error number. > I only really encounter the too many connections message, but there are > reports about other messages on BKO. > > @Thomas: that's out of the scope of kio, it's Dolphin's way of presenting > error messages, so Frank is the person you want for this ;) but yes, using a > labeled "Close" button like Kate does it might help.
Ping? @Thomas: The close button confusion is no longer present since the error icon got removed from the message widget ;) - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110084/#review31289 ----------------------------------------------------------- On May 7, 2013, 7:48 a.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110084/ > ----------------------------------------------------------- > > (Updated May 7, 2013, 7:48 a.m.) > > > Review request for kdelibs and David Faure. > > > Description > ------- > > Remove linebreaks and trim the message so the ugly linebreak at the end > disappears. > > > This addresses bug 318079. > http://bugs.kde.org/show_bug.cgi?id=318079 > > > Diffs > ----- > > kioslave/ftp/ftp.cpp b0868d8 > > Diff: http://git.reviewboard.kde.org/r/110084/diff/ > > > Testing > ------- > > Works and looks much nicer :) > > > File Attachments > ---------------- > > Before > > http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/ftpmessagebefore.png > After > > http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/ftpmsgafter.png > > > Thanks, > > Kai Uwe Broulik > >
