----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110084/#review33249 -----------------------------------------------------------
kioslave/ftp/ftp.cpp <http://git.reviewboard.kde.org/r/110084/#comment24599> QString(psz) looks like a glaring encoding issue. It should be QString::fromUtf8, fromLatin1, fromLocal8Bit ... or possibly KRemoteEncoding. That's probably the best option (same encoding as the filenames themselves, and user-configurable). Yes, the bug was kind of there already :-) - David Faure On May 7, 2013, 7:48 a.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110084/ > ----------------------------------------------------------- > > (Updated May 7, 2013, 7:48 a.m.) > > > Review request for kdelibs and David Faure. > > > Description > ------- > > Remove linebreaks and trim the message so the ugly linebreak at the end > disappears. > > > This addresses bug 318079. > http://bugs.kde.org/show_bug.cgi?id=318079 > > > Diffs > ----- > > kioslave/ftp/ftp.cpp b0868d8 > > Diff: http://git.reviewboard.kde.org/r/110084/diff/ > > > Testing > ------- > > Works and looks much nicer :) > > > File Attachments > ---------------- > > Before > > http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/ftpmessagebefore.png > After > > http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/ftpmsgafter.png > > > Thanks, > > Kai Uwe Broulik > >
