> On June 14, 2013, 10:27 a.m., Albert Astals Cid wrote: > > Hmmm this needs to go to kdelibs too, no? What about the feature freeze > > that kicked in already?
This is exactly the reason why you are CCed explicitly here. I'm aware of the feature freeze and apologize for the too late submission request. But as I understand, kdelibs will be in feature freeze forever once 4.11 is released. So either we push this now, or only for KDE 5. And I would like to get feedback before KDE 5, as for KDE 5 we are able to modify the API again. The patch does not introduce any new i18n strings. The interface is completely documented. Further, the interface is implemented anyway in KatePart, meaning that if this patch is rejected, any application could just copy the .h file and still cast the KTextEditor::Document to KTextEditor::MessageInterface. This, however, is ugly. Instead of such hacky workarounds, I'm asking for an exception and inclusion of this patch in kdelibs master (upcoming 4.11 branch). In KDE 4.11.0 itself, no application (except Kate Part itself) will use this interface. The risk of introducing regressions for 4.11.0 is minimal. And if regressions appear, I will fix them of course ;) - Dominik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111000/#review34346 ----------------------------------------------------------- On June 13, 2013, 5:10 p.m., Dominik Haumann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111000/ > ----------------------------------------------------------- > > (Updated June 13, 2013, 5:10 p.m.) > > > Review request for Kate, kdelibs, Albert Astals Cid, and Christoph Cullmann. > > > Description > ------- > > This patch adds the KTextEditor::MessageInterface to the KTextEditor > interfaces in kdelibs 4.11. > > This interface exists in Kate since KDE 4.10, and is already used internally > to show messages when needed (e.g. search & replace, or swap file recover > bar). By adding this interface to kdelibs, applications like KDevelop, Kile, > etc... can use this interface to show passive interactive notifications in a > KTextEditor::View. > > With this commit, we also want to get feedback by potential users of this > interface, so we can improve/tweak it again for KDE 5 (or whatever it will be > called :) ). > > > Diffs > ----- > > interfaces/ktexteditor/messageinterface.cpp PRE-CREATION > interfaces/ktexteditor/messageinterface.h PRE-CREATION > interfaces/ktexteditor/CMakeLists.txt 9813734 > includes/KTextEditor/MessageInterface PRE-CREATION > includes/KTextEditor/Message PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/111000/diff/ > > > Testing > ------- > > Given the interface is in Kate since KDE 4.10, the interface is quite mature. > > > Thanks, > > Dominik Haumann > >
