----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111000/#review34390 -----------------------------------------------------------
For me it's ok to go on with this freeze exception since it's code that's already in use, but i'd like someone from kdelibs to ack too, maybe dfaure? - Albert Astals Cid On June 14, 2013, 2:41 p.m., Dominik Haumann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111000/ > ----------------------------------------------------------- > > (Updated June 14, 2013, 2:41 p.m.) > > > Review request for Kate, kdelibs, Release Team, and Christoph Cullmann. > > > Description > ------- > > This patch adds the KTextEditor::MessageInterface to the KTextEditor > interfaces in kdelibs 4.11. > > This interface exists in Kate since KDE 4.10, and is already used internally > to show messages when needed (e.g. search & replace, or swap file recover > bar). By adding this interface to kdelibs, applications like KDevelop, Kile, > etc... can use this interface to show passive interactive notifications in a > KTextEditor::View. > > With this commit, we also want to get feedback by potential users of this > interface, so we can improve/tweak it again for KDE 5 (or whatever it will be > called :) ). > > > Diffs > ----- > > interfaces/ktexteditor/messageinterface.cpp PRE-CREATION > interfaces/ktexteditor/messageinterface.h PRE-CREATION > interfaces/ktexteditor/CMakeLists.txt 9813734 > includes/KTextEditor/MessageInterface PRE-CREATION > includes/KTextEditor/Message PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/111000/diff/ > > > Testing > ------- > > Given the interface is in Kate since KDE 4.10, the interface is quite mature. > > > Thanks, > > Dominik Haumann > >
