> On June 24, 2013, 8:38 a.m., Frank Reininghaus wrote: > > Thanks for the patch Dawit! The approach looks good to me, from my point of > > view this can go in unless David has any objections. One little question > > though: is there a reason why you moved the "Trash/Delete"-related code to > > a different location in DolphinContextMenu::openItemContextMenu()? This > > makes the diff larger, and it becomes harder to understand what's going on > > if anyone investigates the file's history at some point in the future.
I moved the code into openItemContextMenu because the change requires access to KFileItemListProperties for checking capabilities. As such the option I had was to either move the code where I did or add a parameter to the insertDefaultItemActions for passing KFileItemListProperties. I just chose to do the latter simply because KFileItemListProperties already exists in openItemContextMenu and no other code in insertDefaultItemActions requires it. I can change it to the latter approach since I have no preference about this. - Dawit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111206/#review34946 ----------------------------------------------------------- On June 24, 2013, 5:58 a.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111206/ > ----------------------------------------------------------- > > (Updated June 24, 2013, 5:58 a.m.) > > > Review request for KDE Base Apps, David Faure and Frank Reininghaus. > > > Description > ------- > > The attached patch fixes which one of the remove actions are shown in both > Dolphin and Konqueror. Its main goal is not to show the "Move To Trash" for > remote protocols, e.g. sftp, smb. As such the patch does the following: > > 1.) For local files, show both the "Move To Trash" and "Delete" actions if > the "ShowDeleteCommand" global option is set. Pressing Shift key will have no > effect. > 2.) For local files, show only "Move To Trash" when the "ShowDeleteCommand" > global option is not set. Pressing the Shift key will change the action to > "Delete". > 3.) For remote files, only show the "Delete" action. Never show the "Move To > Trash" action. > > > This addresses bug 261762. > http://bugs.kde.org/show_bug.cgi?id=261762 > > > Diffs > ----- > > dolphin/src/dolphincontextmenu.cpp 7073dbf > dolphin/src/dolphinpart.cpp 642b150 > > Diff: http://git.reviewboard.kde.org/r/111206/diff/ > > > Testing > ------- > > > Thanks, > > Dawit Alemayehu > >
