----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111206/#review35009 -----------------------------------------------------------
This review has been submitted with commit e688a52e3c84d7f1106911a80492792fd1aadd57 by Dawit Alemayehu to branch master. - Commit Hook On June 24, 2013, 12:15 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111206/ > ----------------------------------------------------------- > > (Updated June 24, 2013, 12:15 p.m.) > > > Review request for KDE Base Apps, David Faure and Frank Reininghaus. > > > Description > ------- > > The attached patch fixes which one of the remove actions are shown in both > Dolphin and Konqueror. Its main goal is not to show the "Move To Trash" for > remote protocols, e.g. sftp, smb. As such the patch does the following: > > 1.) For local files, show both the "Move To Trash" and "Delete" actions if > the "ShowDeleteCommand" global option is set. Pressing Shift key will have no > effect. > 2.) For local files, show only "Move To Trash" when the "ShowDeleteCommand" > global option is not set. Pressing the Shift key will change the action to > "Delete". > 3.) For remote files, only show the "Delete" action. Never show the "Move To > Trash" action. > > > This addresses bug 261762. > http://bugs.kde.org/show_bug.cgi?id=261762 > > > Diffs > ----- > > dolphin/src/dolphincontextmenu.cpp 7073dbf > dolphin/src/dolphincontextmenu.h 160f088 > dolphin/src/dolphinpart.cpp 642b150 > > Diff: http://git.reviewboard.kde.org/r/111206/diff/ > > > Testing > ------- > > > Thanks, > > Dawit Alemayehu > >
