On Sunday 30 June 2013, Mark Gaiser wrote: > > On June 24, 2013, 9:19 a.m., David Faure wrote: > > > kdecore/services/kmimetype.cpp, line 316 > > > <http://git.reviewboard.kde.org/r/111050/diff/3/?file=165328#file165328 > > > line316> > > > > > > I can't review this. It completely forks an existing method > > > (findByUrlHelper), which is already supposed to have a fast path > > > (not reading the contents of the file). So why not improve the > > > existing method, rather than fork it? With this patch, I can't see > > > what you changed compared to the original method, and what might > > > possibly be missing (= regression). > > Right, a very valid case. However considering the speedup has dropped down > to just ~2x...
"to just ~2x..." ... this means it's twice as fast as before, that's a lot ! :-) Alex
