----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111335/#review35907 -----------------------------------------------------------
Almost there, thanks. I'm surprised by the dispatch (to call one of the many uidelegate methods), followed by an un-dispatch (what's the term?), i.e. these many methods all end up calling the same method anyway.... I can see how it makes the uidelegate api look nicer, but this is all internal, nobody else than the slave should end up calling these methods (if apps need messageboxes they can just use KMessageBox directly). I'm not vetoing this solution, maybe you can leave it, I'm just wondering what's the purpose. kio/kio/job_p.h <http://git.reviewboard.kde.org/r/111335/#comment26580> This is a bit long to be all-inline in the header. Why not put the implementation in the .cpp file, where people will be looking for it? kio/kio/slaveinterface.h <http://git.reviewboard.kde.org/r/111335/#comment26581> const int -> int - David Faure On July 13, 2013, 1:30 a.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111335/ > ----------------------------------------------------------- > > (Updated July 13, 2013, 1:30 a.m.) > > > Review request for kdelibs. > > > Description > ------- > > The attached patch addresses one of the oldest bugs in KIO. Due to the > muti-process nature of KIO, if any of the ioslaves encounter something that > requires user input, the user might end up getting prompted multiple times. > The best example of this is SSL error warnings sent to the client by > kio_http. The patch completely resolves this problem using the same approach > as kpasswdserver, but without the need for an additional kded process. > > > This addresses bugs 154100 and 265228. > http://bugs.kde.org/show_bug.cgi?id=154100 > http://bugs.kde.org/show_bug.cgi?id=265228 > > > Diffs > ----- > > kio/CMakeLists.txt 4854829 > kio/kio/job_p.h 0c1fd64 > kio/kio/jobuidelegate.h 25e0728 > kio/kio/jobuidelegate.cpp 85679c2 > kio/kio/scheduler.cpp 802f8b8 > kio/kio/slaveinterface.h 4bfcec8 > kio/kio/slaveinterface.cpp aa0fc44 > kio/kio/slaveinterface_p.h e31ec5e > kio/kio/usernotificationhandler.cpp PRE-CREATION > kio/kio/usernotificationhandler_p.h PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/111335/diff/ > > > Testing > ------- > > Visit a site that throws up SSL warnings and causes KIO to show more than one > error dialog. > > > Thanks, > > Dawit Alemayehu > >
