-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111335/
-----------------------------------------------------------
(Updated July 13, 2013, 7:22 a.m.)
Review request for kdelibs.
Changes
-------
Changed the JobUiDelegate APIs back to a single API that is marked as internal
and corrected other minor issues.
Description
-------
The attached patch addresses one of the oldest bugs in KIO. Due to the
muti-process nature of KIO, if any of the ioslaves encounter something that
requires user input, the user might end up getting prompted multiple times. The
best example of this is SSL error warnings sent to the client by kio_http. The
patch completely resolves this problem using the same approach as
kpasswdserver, but without the need for an additional kded process.
This addresses bugs 154100 and 265228.
http://bugs.kde.org/show_bug.cgi?id=154100
http://bugs.kde.org/show_bug.cgi?id=265228
Diffs (updated)
-----
kio/CMakeLists.txt 4854829
kio/kio/job.cpp 096a7d7
kio/kio/job_p.h 0c1fd64
kio/kio/jobuidelegate.h 25e0728
kio/kio/jobuidelegate.cpp 85679c2
kio/kio/scheduler.cpp 802f8b8
kio/kio/slaveinterface.h 4bfcec8
kio/kio/slaveinterface.cpp aa0fc44
kio/kio/slaveinterface_p.h e31ec5e
kio/kio/usernotificationhandler.cpp PRE-CREATION
kio/kio/usernotificationhandler_p.h PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/111335/diff/
Testing
-------
Visit a site that throws up SSL warnings and causes KIO to show more than one
error dialog.
Thanks,
Dawit Alemayehu
