-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111852/
-----------------------------------------------------------
(Updated Aug. 5, 2013, 1:37 a.m.)
Review request for kdelibs and David Faure.
Changes
-------
Updating the patch to use dfaure's strategy and include unit tests.
Description
-------
Comment information is found in the XML data so needs to be loaded before
returning property values. The same would apply for the Patterns property if
you were to query that from the property name instead of the
KMimeType::patterns() method.
This addresses bug 322578.
http://bugs.kde.org/show_bug.cgi?id=322578
Diffs (updated)
-----
kdecore/services/kmimetype.cpp d748523
kdecore/services/kmimetype_p.h 6ffee71
kdecore/tests/kmimetypetest.h c38b036
kdecore/tests/kmimetypetest.cpp da32e2c
Diff: http://git.reviewboard.kde.org/r/111852/diff/
Testing
-------
Executed the same code posted in the bug report, here's the output:
("Name", "Comment", "Patterns", "Icon")
QVariant(QString, "PNG image")
Thanks,
David Narváez
