----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111852/#review37101 -----------------------------------------------------------
Thanks for the unittest. Almost there :) kdecore/services/kmimetype_p.h <http://git.reviewboard.kde.org/r/111852/#comment27449> Why did you make this a new virtual method? The concept doesn't exist in KServiceType, so I don't see the point. I would have left KMimeType::patterns() unchanged, it seemed fine. You copied the way comment() works, but it's different because there's a KServiceTypePrivate::comment(). - David Faure On Aug. 5, 2013, 1:38 a.m., David Narváez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111852/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2013, 1:38 a.m.) > > > Review request for kdelibs, Albert Astals Cid and David Faure. > > > Description > ------- > > Comment information is found in the XML data so needs to be loaded before > returning property values. The same would apply for the Patterns property if > you were to query that from the property name instead of the > KMimeType::patterns() method. > > > This addresses bug 322578. > http://bugs.kde.org/show_bug.cgi?id=322578 > > > Diffs > ----- > > kdecore/services/kmimetype.cpp d748523 > kdecore/services/kmimetype_p.h 6ffee71 > kdecore/tests/kmimetypetest.h c38b036 > kdecore/tests/kmimetypetest.cpp da32e2c > > Diff: http://git.reviewboard.kde.org/r/111852/diff/ > > > Testing > ------- > > Executed the same code posted in the bug report, here's the output: > > ("Name", "Comment", "Patterns", "Icon") > QVariant(QString, "PNG image") > > > Thanks, > > David Narváez > >
