----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111870/ -----------------------------------------------------------
(Updated Aug. 5, 2013, 5:30 p.m.) Review request for kdelibs and David Faure. Changes ------- Description changed Description (updated) ------- At first i wasn't intending to even ask a reviewrequest for this because i want to fix an issue that is well described in my thread: "KDirWatch bug and the analysis. Help is welcome!" on kde-core-devel. However, while starting on fixing that issue i noticed that this would be a nice small improvement to have. It prevents one stat call that was used to determine if "entry" is a file or folder. Inotify already gives us that information under the IN_ISDIR flag thus i use that instead of the stat call. Diffs ----- kdecore/io/kdirwatch.cpp 95ee3d3 Diff: http://git.reviewboard.kde.org/r/111870/diff/ Testing ------- Compiles just fine. Runs fine, i haven't seen any issues thus far. Oh and it passes all kio test cases but i specially note the following: kdirwatchtest kdirlistertest kdirmodeltest Thanks, Mark Gaiser
