----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111870/#review37241 -----------------------------------------------------------
Ship it! Ship It! - David Faure On Aug. 6, 2013, 7:46 p.m., Mark Gaiser wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111870/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2013, 7:46 p.m.) > > > Review request for kdelibs and David Faure. > > > Description > ------- > > At first i wasn't intending to even ask a reviewrequest for this because i > want to fix an issue that is well described in my thread: "KDirWatch bug and > the analysis. Help is welcome!" on kde-core-devel. However, while starting on > fixing that issue i noticed that this would be a nice small improvement to > have. It prevents one stat call that was used to determine if "entry" is a > file or folder. Inotify already gives us that information under the IN_ISDIR > flag thus i use that instead of the stat call. > > > Diffs > ----- > > kdecore/io/kdirwatch.cpp 95ee3d3 > kdecore/io/kdirwatch_p.h 5800e9a > > Diff: http://git.reviewboard.kde.org/r/111870/diff/ > > > Testing > ------- > > Compiles just fine. > Runs fine, i haven't seen any issues thus far. > Oh and it passes all kio test cases but i specially note the following: > kdirwatchtest > kdirlistertest > kdirmodeltest > > > Thanks, > > Mark Gaiser > >
