> On Aug. 3, 2013, 10:27 p.m., Milian Wolff wrote: > > kdecore/io/kdirwatch.cpp, line 372 > > <http://git.reviewboard.kde.org/r/111870/diff/1/?file=176087#file176087line372> > > > > the indentation is broken here, no? should be two spaces like the rest > > of the file. > > Mark Gaiser wrote: > Actually, the kdirwatch.cpp file is broken in it's entirety when it comes > to indentation. I followed the kdelibs coding style (4 spaces) and kdirwatch > is using a mixture of 2 and 4 spaces. Do you suggest that i use the "mixed" > indentation style for this patch to match the file or the kdelibs style?
No, use what the surrounding code is written in. - Milian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111870/#review37041 ----------------------------------------------------------- On Aug. 5, 2013, 5:30 p.m., Mark Gaiser wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111870/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2013, 5:30 p.m.) > > > Review request for kdelibs and David Faure. > > > Description > ------- > > At first i wasn't intending to even ask a reviewrequest for this because i > want to fix an issue that is well described in my thread: "KDirWatch bug and > the analysis. Help is welcome!" on kde-core-devel. However, while starting on > fixing that issue i noticed that this would be a nice small improvement to > have. It prevents one stat call that was used to determine if "entry" is a > file or folder. Inotify already gives us that information under the IN_ISDIR > flag thus i use that instead of the stat call. > > > Diffs > ----- > > kdecore/io/kdirwatch.cpp 95ee3d3 > > Diff: http://git.reviewboard.kde.org/r/111870/diff/ > > > Testing > ------- > > Compiles just fine. > Runs fine, i haven't seen any issues thus far. > Oh and it passes all kio test cases but i specially note the following: > kdirwatchtest > kdirlistertest > kdirmodeltest > > > Thanks, > > Mark Gaiser > >
