----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review40494 -----------------------------------------------------------
kdeui/colors/kcolorschemetoken.h <http://git.reviewboard.kde.org/r/112880/#comment29808> trailing whitespace kdeui/colors/kcolorschemetoken.h <http://git.reviewboard.kde.org/r/112880/#comment29809> needs an @since version line kdeui/colors/kcolorschemetoken.h <http://git.reviewboard.kde.org/r/112880/#comment29810> while not wrong, I would put it below the main description. kdeui/colors/kcolorschemetoken.cpp <http://git.reviewboard.kde.org/r/112880/#comment29811> opening block brace for function body on separate line kdeui/colors/kcolorschemetoken.cpp <http://git.reviewboard.kde.org/r/112880/#comment29812> I think we prefer C++ style casts over C style casts - Kevin Krammer On Sept. 22, 2013, 4:09 p.m., Denis Kuplyakov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112880/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2013, 4:09 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > It is wrapper to access KColorScheme's methods from QML code. > Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them > accessible from QML code. > > As it will be accepted, QML-clone of KgPopupItem will be posted for review to > libkdegames, as it uses it to access KDE's color theme. > > More info: > * search for "KDE theme colors API for QML" thread at kdelibs and kdegames > mailinglists * > > NEED TO FIX: > I can't include it like #include <KColorSchemeToken> at KReversi's code, only > "kcolorschemetoken.h". Maybe I've missed something? > > > Diffs > ----- > > kdeui/colors/kcolorschemetoken.cpp PRE-CREATION > kdeui/colors/kcolorschemetoken.h PRE-CREATION > kdeui/colors/kcolorscheme.cpp a6650ac > kdeui/colors/kcolorscheme.h 17570fd > kdeui/CMakeLists.txt b439e04 > > Diff: http://git.reviewboard.kde.org/r/112880/diff/ > > > Testing > ------- > > I've tested it with KReversi's deniskup/gsoc2013/newdesign branch. > > > Thanks, > > Denis Kuplyakov > >