> On Sept. 24, 2013, 6:55 a.m., Kevin Ottens wrote: > > I'm not sure we can let that in for kdelibs 4.x / kdeui... David? Any > > opinion? > > > > If we ignore that point for the moment, and think in terms of KF5, ATM it > > would go with KColorScheme in KConfigWidgets. I'm not quite sold on the > > "Token" name though. It comes from the fact that it attempts to be the QML > > API but provided as a C++ API, shouldn't it be in a declarative import > > plugin with no C++ API? That'd put less pressure on the class name.
I still don't like having that in kdeui... What about kdeclarative instead? Not sure the dependencies are acceptable for it though. I'd say let's land it there first and then we'll see. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review40635 ----------------------------------------------------------- On Oct. 6, 2013, 7:24 p.m., Denis Kuplyakov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112880/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2013, 7:24 p.m.) > > > Review request for KDE Frameworks and kdelibs. > > > Repository: kdelibs > > > Description > ------- > > It is wrapper to access KColorScheme's methods from QML code. > Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them > accessible from QML code. > > As it will be accepted, QML-clone of KgPopupItem will be posted for review to > libkdegames, as it uses it to access KDE's color theme. > > More info: > * search for "KDE theme colors API for QML" thread at kdelibs and kdegames > mailinglists * > > > Diffs > ----- > > kdeui/CMakeLists.txt b439e04 > includes/CMakeLists.txt cdf0143 > includes/KColorSchemeToken PRE-CREATION > kdeui/colors/kcolorscheme.h 17570fd > kdeui/colors/kcolorscheme.cpp a6650ac > kdeui/colors/kcolorschemetoken.h PRE-CREATION > kdeui/colors/kcolorschemetoken.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/112880/diff/ > > > Testing > ------- > > I've tested it with KReversi's deniskup/gsoc2013/newdesign branch. > > > Thanks, > > Denis Kuplyakov > >
