-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114519/
-----------------------------------------------------------

(Updated Dec. 20, 2013, 7:11 p.m.)


Review request for kdelibs.


Changes
-------

Narrowed down both compressing/decompressing loops following David Faure's 
suggestion. A lower limit of zero is also too low, since squeezing with less 
than 5 characters is anyways not done.


Bugs: 328263
    http://bugs.kde.org/show_bug.cgi?id=328263


Repository: kdelibs


Description
-------

If KLineEdit has squeezed text enabled, but the widget has still zero width, 
KLineEdit::setSqueezedText() can go into an endless loop trying to remove more 
than all letters from the string. This patch fixes both this underrun and the 
corresponding possible overrun if the squeezed text is too small. The underrun 
is responsible for endless loops in digikam, see the corresponding bug report.


Diffs (updated)
-----

  kdeui/widgets/klineedit.cpp 2193ef2969d49ad602e66da7776feda4b7595b13 

Diff: http://git.reviewboard.kde.org/r/114519/diff/


Testing
-------


Thanks,

Axel Arnold

Reply via email to