----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114519/#review45970 -----------------------------------------------------------
Ship it! Should go into 4.12 and the kcompletion framework. If you don't have a contributor's account, I can push the commit. - David Faure On Dec. 20, 2013, 7:11 p.m., Axel Arnold wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114519/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2013, 7:11 p.m.) > > > Review request for kdelibs. > > > Bugs: 328263 > http://bugs.kde.org/show_bug.cgi?id=328263 > > > Repository: kdelibs > > > Description > ------- > > If KLineEdit has squeezed text enabled, but the widget has still zero width, > KLineEdit::setSqueezedText() can go into an endless loop trying to remove > more than all letters from the string. This patch fixes both this underrun > and the corresponding possible overrun if the squeezed text is too small. The > underrun is responsible for endless loops in digikam, see the corresponding > bug report. > > > Diffs > ----- > > kdeui/widgets/klineedit.cpp 2193ef2969d49ad602e66da7776feda4b7595b13 > > Diff: http://git.reviewboard.kde.org/r/114519/diff/ > > > Testing > ------- > > > Thanks, > > Axel Arnold > >
