----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116783/#review52887 -----------------------------------------------------------
Looks good, apart from method name and coding style (spaces in all sorts of wrong places, for historic reasons - OK to leave as it here, but run astyle-kdelibs or clean by hand after patching the kio framework, which has been made consistent style-wise). kioslave/ftp/ftp.cpp <https://git.reviewboard.kde.org/r/116783/#comment37232> It's a bit confusing to have two methods called ftpSize. Maybe call this one ftpSizeCmd() or something? (check existing method names for consistency) - David Faure On March 13, 2014, 12:33 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116783/ > ----------------------------------------------------------- > > (Updated March 13, 2014, 12:33 p.m.) > > > Review request for kdelibs and David Faure. > > > Repository: kdelibs > > > Description > ------- > > I completely missed ftpFileExists issued a SIZE command to determine the > existence of a file when addressing bug# 326292. See > https://git.reviewboard.kde.org/r/116524/ review request. The attached patch > addresses that oversight to insure renaming files work properly on the > android ftp server listed in the bug report. > > > Diffs > ----- > > kioslave/ftp/ftp.h cbcd096 > kioslave/ftp/ftp.cpp b9d90e6 > > Diff: https://git.reviewboard.kde.org/r/116783/diff/ > > > Testing > ------- > > Rerun all the tests run for 116524. > > > Thanks, > > Dawit Alemayehu > >
