> On March 13, 2014, 1:10 p.m., David Faure wrote: > > kioslave/ftp/ftp.cpp, line 2302 > > <https://git.reviewboard.kde.org/r/116783/diff/3/?file=253646#file253646line2302> > > > > Misunderstanding, I wasn't talking about indentation (which indeed ends > > up being 4 spaces everywhere in frameworks). The issue is more: no space > > after this "if", one space too many after "psz" on the previous line, too > > many spaces inside the parenthesis on the line "Ftp::ftpSize( ... )", etc. > > > > My suggestion was to just do this automatically in frameworks using a > > tool, otherwise you have to do it correctly by hand :-)
I will use the tool you mentioned for frameworks, but for this one I have tried to fix all the glaring ones you mentioned - Dawit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116783/#review52891 ----------------------------------------------------------- On March 13, 2014, 10:15 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116783/ > ----------------------------------------------------------- > > (Updated March 13, 2014, 10:15 p.m.) > > > Review request for kdelibs and David Faure. > > > Repository: kdelibs > > > Description > ------- > > I completely missed ftpFileExists issued a SIZE command to determine the > existence of a file when addressing bug# 326292. See > https://git.reviewboard.kde.org/r/116524/ review request. The attached patch > addresses that oversight to insure renaming files work properly on the > android ftp server listed in the bug report. > > > Diffs > ----- > > kioslave/ftp/ftp.h cbcd096 > kioslave/ftp/ftp.cpp b9d90e6 > > Diff: https://git.reviewboard.kde.org/r/116783/diff/ > > > Testing > ------- > > Rerun all the tests run for 116524. > > > Thanks, > > Dawit Alemayehu > >
