> On Sept. 20, 2014, 12:26 a.m., Christoph Feck wrote: > > You added APPLE to the if() but not always to the matching endif()... > > René J.V. Bertin wrote: > True. But that's optional, no?
On Saturday September 20 2014, Rolf Eike Beer wrote regarding "Re: Review Request 120287: [OS X] make kde-workspace build" >The endif needs to have either a matching argument to the last if or elseif, >or an entirely empty argument. OK, I'd never noticed issues when not doing so, I'm pretty sure not even when testing the changed files on Linux (which is a bit why I stopped being strict about it). Does the same apply to `else`? I'm not sure that repeating the same complex argument list improves readability all the time, so would it b acceptable if I put an empty argument in places that get too cluttered otherwise? - René J.V. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120287/#review67010 ----------------------------------------------------------- On Sept. 20, 2014, 12:05 a.m., René J.V. Bertin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120287/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2014, 12:05 a.m.) > > > Review request for KDE Software on Mac OS X and kde-workspace. > > > Repository: kde-workspace > > > Description > ------- > > A few rather straightforward patches to make the relevant bits of KDE4's > kde-workspace build and function on OS X. > The main interest is having the systemsettings control panel to control the > various relevant KDE settings among which desktop search, fonts, colours and > even style. > The oxygen style builds and looks good but shows some updating glitches due > to compositing. > > I'm submitting this patch partly in hope it may be useful in bringing > kf5-workspace to OS X, one day. > > > Diffs > ----- > > CMakeLists.txt 195f99c > kcontrol/CMakeLists.txt fc666b1 > kcontrol/krdb/krdb.cpp 36fc99c > kcontrol/style/CMakeLists.txt d832b20 > libs/CMakeLists.txt c0576fe > > Diff: https://git.reviewboard.kde.org/r/120287/diff/ > > > Testing > ------- > > On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs > git/master, 4.14.1). > > > Thanks, > > René J.V. Bertin > >
