> On Sept. 20, 2014, 10:20 vorm., Martin Gräßlin wrote: > > libs/CMakeLists.txt, line 10 > > <https://git.reviewboard.kde.org/r/120287/diff/3/?file=313630#file313630line10> > > > > why is that Darwin and all other cases are APPLE? > > René J.V. Bertin wrote: > Good one. Look just a bit down from that location, you'll see another > "Darwinism" that was there when I set out changing. I guess the line 10 > change was one of the 1st I made, and I never got around to changing it to an > APPLE when I made my later changes. > > It's probably better actually to standardise to APPLE, because there *is* > another OS that uses (or might use) the Darwin keyword (OpenDarwin, > PureDarwin), and that OS will probably use X11. Not sure it'll ever gain > momentum or even run Qt, but best pick a single keyword right now, no?
yes, I think standardise on one keywoards would be good. Though I do not know which one is the best. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120287/#review67023 ----------------------------------------------------------- On Sept. 20, 2014, 12:05 vorm., René J.V. Bertin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120287/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2014, 12:05 vorm.) > > > Review request for KDE Software on Mac OS X and kde-workspace. > > > Repository: kde-workspace > > > Description > ------- > > A few rather straightforward patches to make the relevant bits of KDE4's > kde-workspace build and function on OS X. > The main interest is having the systemsettings control panel to control the > various relevant KDE settings among which desktop search, fonts, colours and > even style. > The oxygen style builds and looks good but shows some updating glitches due > to compositing. > > I'm submitting this patch partly in hope it may be useful in bringing > kf5-workspace to OS X, one day. > > > Diffs > ----- > > CMakeLists.txt 195f99c > kcontrol/CMakeLists.txt fc666b1 > kcontrol/krdb/krdb.cpp 36fc99c > kcontrol/style/CMakeLists.txt d832b20 > libs/CMakeLists.txt c0576fe > > Diff: https://git.reviewboard.kde.org/r/120287/diff/ > > > Testing > ------- > > On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs > git/master, 4.14.1). > > > Thanks, > > René J.V. Bertin > >
