> On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 225-234 > > <https://git.reviewboard.kde.org/r/120287/diff/3/?file=313626#file313626line225> > > > > tabs instead of whitespaces > > René J.V. Bertin wrote: > I looked into those yesterday, and cannot find tabs on my end. No idea > where they'd come from. > > Martin Gräßlin wrote: > I'd guess the editor you use changes it somehow. I'd suggest to use Kate > and enable show all whitespaces.
No, really, those tabs aren't there. I re-reopened the CMakeLists.txt in vi (which doesn't modify anything unless I ask for it) and there are no tabs to be found. Same in KDevelop when I open the patch review tool. I wonder if your editor isn't the culprit, or something on reviewboard? I copied the .reviewboardrc file from another KDE project and edited the obvious settings. I see nothing concerning tabs in there, but maybe there ought to be? - René J.V. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120287/#review67023 ----------------------------------------------------------- On Sept. 20, 2014, 12:05 a.m., René J.V. Bertin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120287/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2014, 12:05 a.m.) > > > Review request for KDE Software on Mac OS X and kde-workspace. > > > Repository: kde-workspace > > > Description > ------- > > A few rather straightforward patches to make the relevant bits of KDE4's > kde-workspace build and function on OS X. > The main interest is having the systemsettings control panel to control the > various relevant KDE settings among which desktop search, fonts, colours and > even style. > The oxygen style builds and looks good but shows some updating glitches due > to compositing. > > I'm submitting this patch partly in hope it may be useful in bringing > kf5-workspace to OS X, one day. > > > Diffs > ----- > > CMakeLists.txt 195f99c > kcontrol/CMakeLists.txt fc666b1 > kcontrol/krdb/krdb.cpp 36fc99c > kcontrol/style/CMakeLists.txt d832b20 > libs/CMakeLists.txt c0576fe > > Diff: https://git.reviewboard.kde.org/r/120287/diff/ > > > Testing > ------- > > On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs > git/master, 4.14.1). > > > Thanks, > > René J.V. Bertin > >
