----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122471/#review75584 -----------------------------------------------------------
about/kio_about.cpp <https://git.reviewboard.kde.org/r/122471/#comment52281> QApplication app(argc, argv); app.setApplicationName(QLatin1String("kio_about")); => you remove KComponentData which is in kdelibs4support - Laurent Montel On fév. 7, 2015, 10:23 après-midi, David Narváez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122471/ > ----------------------------------------------------------- > > (Updated fév. 7, 2015, 10:23 après-midi) > > > Review request for kde-workspace and David Faure. > > > Repository: kio-extras > > > Description > ------- > > Basically porting away from QUrl and KDE_EXPORT > > > Diffs > ----- > > CMakeLists.txt 3379ce7 > about/kio_about.h 620d6aa > about/kio_about.cpp d7396d8 > > Diff: https://git.reviewboard.kde.org/r/122471/diff/ > > > Testing > ------- > > Tested compilation and installation: > > $ find /home/david/kio-install/ -name "*about*" > /home/david/kio-install/lib64/plugins/kio_about.so > > /home/david/kio-install/share/kservices5/about.protocol > > > Thanks, > > David Narváez > >