----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122471/#review75657 -----------------------------------------------------------
Seems good. Did you changed commit message as David told you ? Otherwise ship it. - Laurent Montel On fév. 9, 2015, 6:03 matin, David Narváez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122471/ > ----------------------------------------------------------- > > (Updated fév. 9, 2015, 6:03 matin) > > > Review request for kde-workspace and David Faure. > > > Repository: kio-extras > > > Description > ------- > > Basically porting away from QUrl and KDE_EXPORT > > > Diffs > ----- > > CMakeLists.txt 3379ce7 > about/kio_about.h 620d6aa > about/kio_about.cpp d7396d8 > > Diff: https://git.reviewboard.kde.org/r/122471/diff/ > > > Testing > ------- > > Tested compilation and installation: > > $ find /home/david/kio-install/ -name "*about*" > /home/david/kio-install/lib64/plugins/kio_about.so > > /home/david/kio-install/share/kservices5/about.protocol > > > Thanks, > > David Narváez > >
