----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122556/#review75971 -----------------------------------------------------------
AFAIK our CI system doesn't support Qt 5.4 yet. I think we should first ensure the CI system is prepared for building with the new dependency. - Martin Gräßlin On Feb. 13, 2015, 9:06 a.m., Arjun AK wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122556/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2015, 9:06 a.m.) > > > Review request for KDE Base Apps. > > > Repository: kde-baseapps > > > Description > ------- > > `QUrl::fromUserInput(userInput, workingDirectory, UserInputResolutionOptions > options)` seems to be Qt 5.4+. We either need to bump requirement to 5.4 or > do what kompare > [did](https://projects.kde.org/projects/kde/kdesdk/kompare/repository/revisions/master/entry/libdialogpages/diffpage.cpp#L45) > > > Diffs > ----- > > CMakeLists.txt 6df9015 > > Diff: https://git.reviewboard.kde.org/r/122556/diff/ > > > Testing > ------- > > > Thanks, > > Arjun AK > >