> On Feb. 13, 2015, 10:39 nachm., Marko Käning wrote: > > I'd vote for keeping it compatible to Qt 5.3, if that's possible. > > Inge Wallin wrote: > +1. Depending on 5.4 in applications already is bad enough even though it > can sometimes be necessary but I am against it for our base stuff. Especially > in this case where there is a workaround.
Note that nothing from the "frameworks" branch in kde-baseapps has been released yet. OTOH, Qt 5.4 was released more than 2 months ago. Is it likely that any distro will ship stuff that is released from kde-baseapps/frameworks at some point in the future, but still stick to Qt 5.3? - Frank ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122556/#review76012 ----------------------------------------------------------- On Feb. 13, 2015, 8:06 vorm., Arjun AK wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122556/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2015, 8:06 vorm.) > > > Review request for KDE Base Apps. > > > Repository: kde-baseapps > > > Description > ------- > > `QUrl::fromUserInput(userInput, workingDirectory, UserInputResolutionOptions > options)` seems to be Qt 5.4+. We either need to bump requirement to 5.4 or > do what kompare > [did](https://projects.kde.org/projects/kde/kdesdk/kompare/repository/revisions/master/entry/libdialogpages/diffpage.cpp#L45) > > > Diffs > ----- > > CMakeLists.txt 6df9015 > > Diff: https://git.reviewboard.kde.org/r/122556/diff/ > > > Testing > ------- > > > Thanks, > > Arjun AK > >
